Add typing to aiida/common/{utils,extendeddicts}.py #6706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## update-mypy #6706 +/- ##
===============================================
+ Coverage 79.15% 79.15% +0.01%
===============================================
Files 566 566
Lines 43404 43407 +3
===============================================
+ Hits 34351 34354 +3
Misses 9053 9053 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
danielhollas
force-pushed
the
common-typing
branch
from
55d03cd to
819f5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the typing of the
aiida.commonmodule.The types in
extendeddicts.pyis kind of shoddy, and some function signatures are not typed since all the classes there are super-generic so they would all be mostly Any anyway. But I think it is still better than nothing and it is better than ignoring this file entirely.Depends on #6704